-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Add page on the Android sensitive content feature #12220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Visit the preview URL for this PR (updated for commit 5c637f1): https://flutter-docs-prod--pr12220-sensitive-content-3cgantvq.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this is in Draft mode, but I reviewed it anyway. :D
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Co-authored-by: Shams Zakhour (ignore Sfshaza) <[email protected]>
Learn how to protect sensitive content in your Flutter app. | ||
--- | ||
|
||
This feature has landed in Flutter 3.35 and is available on Android API 35+. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we normally indicate what flutter version first introduced a feature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops I thought we did but I don't see any examples in https://docs.flutter.dev/platform-integration/android! Removed.
|
||
## Using the `SensitiveContent` widget | ||
|
||
Given some content that you want to protect from media screen share |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Include somewhere in this doc if users need to worry about using sensitive content on non android or non api 35+ platforms and what the fallback behavior is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was already included in the section above but added a note here, as well.
When running on Android API 35+, this code will have no effect, so the screen | ||
will never been obscured during media projection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When running on Android API 35+, this code will have no effect, so the screen | |
will never been obscured during media projection. | |
When running on Android API 34 and below, the screen will not been obscured during media projection. The widget will exist in the tree but has no other effect and you do not need to avoid usages of Sensitive content on platforms that do not have support. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing catch--thank you!
@sfshaza2 Do you want to take another look here or is this good to land? |
Description of what this PR is changing or adding, and why:
Adds page covering the sensitive content protection feature on Android as it is being released in the next stable version.
Issues fixed by this PR (if any):
N/A
PRs or commits this PR depends on (if any):
N/A
Presubmit checklist
of 80 characters or fewer.